Ticket #731 (new defect)

Opened 14 months ago

Last modified 14 months ago

lib330 and miniseed

Reported by: philip Owned by: somebody
Priority: major Milestone:
Component: q3302ew Version: 7.10
Keywords: lib330 Cc: crotwell@…

Description

A year or so ago I tried to enable miniseed packets within q330 to have it send the configuration periodically as OCF and with kinemetrics help found there is a bug in lib330 that prevents this. I didn't follow up this idea, but thought I would post a bug report just so this isn't lost.

Attached are the email from kinemetrics with the issue, and a patch against earthworm10 with the changes.

Basically, the bitwise mini_filter should be

and (OMF_ALL or OMF_CFG or OMF_TIM or OMF_MSG) ;

instead of

and OMF_ALL ;

I think the libsampcfg patch should probably be applied, even though the kinemetrics folks seemed cautious. The q3302ew patch is a little bit more involved, basically allowing the q330 to send miniseed in addition to the one second packets. I don't know how commonly useful this would be, but would allow the OCF packets, which would mean that the configuration of the logger could be recorded as a datastream, which might be useful in detecting metadata changes or automated checking to see if the metadata accurately reflects the configuration.

Anyway, hope this is useful to someone.

Attachments

kinemetrics_email.txt (3.7 KB) - added by philip 14 months ago.
email from kinemetrics tech support
ew7.10_libsampcfg.patch (1.1 KB) - added by philip 14 months ago.
patch to libsampcfg in lib330
ew7.10_q3302ew.patch (10.3 KB) - added by philip 14 months ago.
patch to allow miniseed from q330
crotwell_email.txt (3.1 KB) - added by philip 14 months ago.
original email to kinemetrics, background and testing

Change History

Changed 14 months ago by philip

email from kinemetrics tech support

Changed 14 months ago by philip

patch to libsampcfg in lib330

Changed 14 months ago by philip

patch to allow miniseed from q330

Changed 14 months ago by philip

original email to kinemetrics, background and testing

comment:1 Changed 14 months ago by paulf

Hi Philip,

THanks for making this change. I looked it over and it makes sense to me. This is a really good addition to q3302ew. If you have tested these changes, and I trust that you did, then I think you should put them safely into SVN repo..We are still no ready to move to a git repo. Let me know via direct email if you need your SVN account password again.

Sincerely,

Paul

comment:2 Changed 14 months ago by philip

I commited the lib330 patch. I think I might try a little more testing when I get a chance on the q3302ew as it has more moving parts.

comment:3 Changed 14 months ago by philip

OK, I have committed the changes in http://earthworm.isti.com/trac/earthworm/changeset/8270.

Probably a good idea for someone else to run any tests you usually run on the q3302ew module.

comment:4 Changed 14 months ago by philip

Question, how does the html docs work generation work? There is a q3302ew_cmd.html in src/data_sources/q3302ew and another in doc/WEB_DOC/cmd/q3302ew_cmd.html. I added to the first, but didn't do anything to the second.

I would humbly suggest that two copies of the same file in svn is a bad idea.

comment:5 Changed 14 months ago by paulf

We should remove the copy in the src directory. The one in the WEB_DOC/cmd should be authoritative. Sorry for taking so long to get back to you Philip!!

Note: See TracTickets for help on using tickets.