Ticket #439 (new defect)

Opened 8 years ago

Last modified 8 years ago

The params/*.d and params/*.desc files are out of sync with the src/... files

Reported by: baker Owned by: somebody
Priority: minor Milestone: All Platforms
Component: ALL modules Version: 7.8
Keywords: params Cc:

Description

The .d files and .desc in the params/ directory are out of sync with the (master?) files in the src/ directories: 28 .d files differ, 16 src .d files do not exist, and 13 .desc files differ.

$ find src -type f -name \*.d -not -execdir diff -q {} "/Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/{}" ';'
Files nq2wws.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/nq2wws.d differ
Files getfile_ew.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/getfile_ew.d differ
Files grf2ew.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/grf2ew.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
Files startstop_nt.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_nt.d differ
Files startstop_unix.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_unix.d differ
Files statmgr.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
Files wave_viewer.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_viewer.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
Files srpar2ew.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/srpar2ew.d differ
Files startstop_nt.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_nt.d differ
Files startstop_unix.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_unix.d differ
Files statmgr.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
Files wave_viewer.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_viewer.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
Files srpar2ew.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/srpar2ew.d differ
Files startstop_nt.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_nt.d differ
Files startstop_unix.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_unix.d differ
Files statmgr.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
Files wave_viewer.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_viewer.d differ
Files srpar2ew.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/srpar2ew.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
Files startstop_nt.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_nt.d differ
Files startstop_unix.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_unix.d differ
Files statmgr.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.d differ
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
Files wave_viewer.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_viewer.d differ
Files wave_viewer.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_viewer.d differ
Files wave_viewer.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_viewer.d differ
Files glass_assoc.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/glass_assoc.d differ
Files localmag.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/localmag.d differ
Files nll_mgr.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/nll_mgr.d differ
Files startstop_nt.d and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop_nt.d differ
$ find src -type f -name \*.d -not -execdir diff -q {} "/Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/{}" ';' | wc
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/earthworm_global.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_nt.d: No such file or directory
diff: /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV_ux.d: No such file or directory
      28     140    2916
$ find src -type f -name \*.desc -not -execdir diff -q {} "/Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/{}" ';'
Files statmgr.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.desc differ
Files wave_serverV.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV.desc differ
Files srpar2ew.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/srpar2ew.desc differ
Files statmgr.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.desc differ
Files wave_serverV.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV.desc differ
Files srpar2ew.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/srpar2ew.desc differ
Files statmgr.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.desc differ
Files wave_serverV.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV.desc differ
Files srpar2ew.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/srpar2ew.desc differ
Files statmgr.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/statmgr.desc differ
Files wave_serverV.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/wave_serverV.desc differ
Files startstop.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop.desc differ
Files startstop.desc and /Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/startstop.desc differ
$ find src -type f -name \*.desc -not -execdir diff -q {} "/Users/baker/Desktop/Software/Earthworm/earthworm_7.7/params/{}" ';' | wc
      13      65    1406

Which are authoritative? Which are maintained?

This is poor practice. My recommendation is to remove the files in params/ and maintain the .d and .desc files along with the source files in the src/ tree. Let the make file populate params/; don't do it in the trunk.

Change History

comment:1 Changed 8 years ago by paulf

Larry,

The src .d files are authoritative. We copy them to the params dir as a convenience and as a reference for each release at the time of release. We don't do it as part of the make because we only want this done at release time. There you have it.

Paul

comment:2 Changed 8 years ago by baker

Why, then, is there a params/ directory in the trunk? That should not be there at all if it is supposed to be created only at the time of a release. All it does is confuse things.

I think using the make file machinery to create/update the params/ files is preferable. That makes it obvious from the distribution files what src/ files got copied to params/ (e.g., there are several different startstop_nt.d files).

Note: See TracTickets for help on using tickets.