Custom Query (541 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (25 - 27 of 541)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
Ticket Resolution Summary Owner Reporter
#150 fixed make clean_unix leaves libsrc/lib330/lib330.a behind somebody baker
Description

make clean_unix does not remove src/libsrc/lib330/lib330.a.

The simple fix is to add two lines to the clean_unix target commands in src/Makefile to clean libsrc/lib330:

 	(cd libsrc/unix; echo Cleaning in:; pwd; \
		make -f makefile.ux clean);
	(cd libsrc/lib330; echo Cleaning in:; pwd; \
		make clean);
	(cd libsrc/util/gd_lib; echo Cleaning in:; pwd; \
		make -f makefile.ux clean);

However, src/libsrc has makefile's with clean targets that would have taken care of this. Shouldn't src/Makefile use the src/libsrc/makefile's to do the clean, rather than (mistakenly) replicate the clean commands itself?

#151 wontfix Use POSIX termios functions in srpar2ew somebody baker
Description

gcc version 4.2.1 (Mac OS X 10.5.8) has errors when compiling src/data_sources/srpar2ew/pargps/lib/pargps.c:

gcc -c -g -m32 -D_MACOSX -D_INTEL -D_GFORTRAN -D_USE_PTHREADS -D_USE_SCHED -I/Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/include -fPIC -DSROS_LINUX -DSRA2D_PARANY -DGPS_AVAILABLE -I/Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/src/data_sources/srpar2ew/pargps/include /Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/src/data_sources/srpar2ew/pargps/lib/pargps.c
/Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/src/data_sources/srpar2ew/pargps/lib/pargps.c: In function ‘ParGpsOsSerialInit’:
/Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/src/data_sources/srpar2ew/pargps/lib/pargps.c:5519: error: ‘CBAUD’ undeclared (first use in this function)
/Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/src/data_sources/srpar2ew/pargps/lib/pargps.c:5519: error: (Each undeclared identifier is reported only once
/Users/baker/Desktop/Software/Earthworm/earthworm-7.5/merged/src/data_sources/srpar2ew/pargps/lib/pargps.c:5519: error: for each function it appears in.)

This is because CBAUD is a Linux extension to the POSIX Terminal I/O definitions. The fix is to use the standard POSIX Terminal I/O functions to set the serial input and output BAUD rates (e.g., if CBAUD is undefined):

        NewSettings.c_oflag &= ~OPOST;   // output processing not applied

        // CBAUD is a Linux extension to the POSIX termios.h Terminal I/O
        // definitions.  See O'Reilly, POSIX Programmer's Guide, Chapter 8.
        // Use the POSIX cfsetispeed()/cfsetospeed() functions to set the
        // input/output BAUD rate if CBAUD is not defined.

#ifdef CBAUD
        NewSettings.c_cflag &= ~CBAUD;   // baudrate mask
        NewSettings.c_cflag |=  B4800;   // baudrate 4800
#else
        cfsetispeed( &NewSettings, B4800 );
        cfsetospeed( &NewSettings, B4800 );
#endif
        NewSettings.c_cflag &= ~CSIZE;   // data bit mask
        NewSettings.c_cflag |=  CS8;     // 8 data bits
        NewSettings.c_cflag &= ~CSTOPB;  // use 1 stop bits not 2
#152 fixed Make sure source files end with a newline character somebody baker
Description

gcc version 4.1.2 (CentOS 5.6 x86_64) complains (warnings) when source/header files are not terminated by a newline character. This is an annoyance that makes it harder to spot meaningful errors and warnings.

I also like to concatenate all the Fortran source files in a program (like hyp2000) to do global (whole file) analysis. When I did that for hyp2000, I found a couple files without newlines at the end, which caused syntax errors when I tried to compile the whole program in one source file.

Attached it a bash shell script that will scan through "trunk" looking for text files without newlines at the end, ignoring any files that are in the .svn directories.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19
Note: See TracQuery for help on using queries.