Ticket #553 (assigned defect)

Opened 3 years ago

Last modified 3 years ago

GSE 64 bit compile fails Ubuntu 14

Reported by: stefan Owned by: et
Priority: critical Milestone: Linux 64bit
Component: waveman2disk Version: 7.9
Keywords: Cc:

Description

Reported by Jon Rusho:

EWBITS=64, gcc and gfortran installed on Ubuntu 14.04.1 x86_64.

And the first problem...

/usr/bin/gcc -g -c -c -D_REENTRANT -m64 -Dlinux -D__i386 -D_LINUX -D_INTEL -D_USE_SCHED  -D_USE_PTHREADS -D_USE_TERMIOS -I/opt/earthworm/earthworm_7.8/include -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter -Wno-unknown-pragmas -Wno-pragmas -Werror=format -g gseputaway.c
gseputaway.c: In function â:
gseputaway.c:175:18: warning: variable â set but not used [-Wunused-but-set-variable]
   TRACE2_HEADER *trace_hdr;
                  ^
gseputaway.c: In function â:
gseputaway.c:579:5: error: format not a string literal and no format arguments [-Werror=format-security]
     fprintf (gse_fp, string);

Change History

comment:1 Changed 3 years ago by et

  • Owner changed from somebody to et
  • Status changed from new to assigned

The line in question (579) did not change, but the Unix build now has more warnings enabled, so this issue was flagged. The fix is to add a '%s' format string to the statement, which I've done and committed. (Also removed unused 'trace_hdr' variable.)

http://earthworm.isti.com/trac/earthworm/changeset/6807

--ET

Note: See TracTickets for help on using tickets.