Ticket #454 (closed defect: fixed)

Opened 5 years ago

Last modified 6 months ago

Several Makefile's hard code gcc/gfortran -m32

Reported by: baker Owned by: somebody
Priority: minor Milestone: Linux
Component: ALL modules Version: 7.8
Keywords: Makefile m32 Cc:

Description

Several Makefile's hard code the gcc/gfortran -m32 compiler option. This prevents them from compiling on platforms which do not support the -m32 option, such as ARM.

$ find /Users/baker/Desktop/Software/Earthworm/earthworm-7.7-6058/src -type f -iname makefile\* -exec grep [-]m32 {} ';' -ls
	@$(MAKE) "CC=$(GCC)" "CFLAGS=-m32 $(GCCFLAGS)"
	$(MAKE) "CC=$(GCC)" "CFLAGS=-g -m32 $(GCCFLAGS)"
	$(MAKE) "CC=$(GCC)" "CFLAGS=-pg -m32 $(GCCFLAGS)"
2880008035        8 -rw-r--r--    1 baker    GS\domain users     1194 Jul 25  2013 /Users/baker/Desktop/Software/Earthworm/earthworm-7.7-6058/src/data_sources/winsdr2ew/mseed/makefile.unix
C32	= -m32
2880009553       40 -rw-r--r--    1 baker    GS\domain users    17584 Jul 15  2013 /Users/baker/Desktop/Software/Earthworm/earthworm-7.7-6058/src/libsrc/qlib2/Makefile
	@$(MAKE) "CC=$(GCC)" "CFLAGS=-m32 $(GCCFLAGS)"
	$(MAKE) "CC=$(GCC)" "CFLAGS=-g -m32 $(GCCFLAGS)"
2880009739        8 -rw-r--r--    1 baker    GS\domain users      894 Feb  6  2007 /Users/baker/Desktop/Software/Earthworm/earthworm-7.7-6058/src/libsrc/util/libmseed/example/Makefile
	@$(MAKE) "CC=$(GCC)" "CFLAGS=-m32 $(GCCFLAGS)"
	$(MAKE) "CC=$(GCC)" "CFLAGS=-g -m32 $(GCCFLAGS)"
	$(MAKE) "CC=$(GCC)" "CFLAGS=-pg -m32 $(GCCFLAGS)"
2880009636        8 -rw-r--r--    1 baker    GS\domain users     1917 May  7  2013 /Users/baker/Desktop/Software/Earthworm/earthworm-7.7-6058/src/libsrc/util/libmseed/Makefile
#FFLAGS=-m32 -g
2880011073       16 -rw-r--r--    1 baker    GS\domain users     5165 Jan 28  2013 /Users/baker/Desktop/Software/Earthworm/earthworm-7.7-6058/src/seismic_processing/hyp2000_mgr/makefile.unix

Should not all Makefile's use the CFLAGS and FFLAGS environment variables? If they did, this would not be a problem.

Change History

comment:1 Changed 6 months ago by baker

  • Status changed from new to closed
  • Resolution set to fixed

I removed the hard-coded -m32 from all the remaining makefile's where GLOBALFLAGS is used in the $(CC) command. Only two instances remain:

src/data_sources/winsdr2ew/mseed/makefile.unix
src/libsrc/qlib2/Makefile

Those instances are not used.

Fixed in r7460 and r7461.

Note: See TracTickets for help on using tickets.